On Fri, 28 Feb 2025 02:40:10 GMT, Vladimir Kozlov <k...@openjdk.org> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> More friends. > > src/hotspot/share/runtime/vmStructs.cpp line 706: > >> 704: volatile_nonstatic_field(MonitorList, _head, >> ObjectMonitor*) \ >> 705: >> \ >> 706: unchecked_c2_static_field(Matcher, _regEncode, >> sizeof(Matcher::_regEncode)) /* NOTE: no type */ \ > > I don't see usage in SA of `VMReg::regEncode()` which access this field. This code isn't used but I thought it was somehow needed for stack dumping in one of the Xcomp/SA tests. But it was really using the presence of the Matcher type to see if isServerCompiler(). So I added the COMPILER2 preprocessor macro and use that instead. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23782#discussion_r1975629323
