On Mon, 17 Mar 2025 23:44:40 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Larry Cable has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Merge branch 'JDK-8344671' of github.com:larry-cable/jdk into JDK-8344671 >> - JDK-8344671: removed JFR tests from problemlist resolved by this fix > > src/jdk.attach/macosx/native/libattach/VirtualMachineImpl.c line 140: > >> 138: const int caught = (kiproc.kp_proc.p_sigcatch & >> sigmask(SIGQUIT)) != 0; >> 139: >> 140: // *only* send QUIT if the target is ready to catch and handle >> the signal to avoid default "death" if not > > Delete this comment. Please delete as we have already said this above at line 134-135. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24085#discussion_r2017959863
