On Fri, 28 Mar 2025 17:13:27 GMT, Larry Cable <d...@openjdk.org> wrote:
>> src/jdk.attach/macosx/native/libattach/VirtualMachineImpl.c line 148:
>>
>>> 146:
>>> 147: if (caught && !ignored) {
>>> 148: if (kill((pid_t)pid, SIGQUIT)) {
>>
>> Style nit: no implicit booleans
>> Suggestion:
>>
>> if (kill((pid_t)pid, SIGQUIT) != 0) {
>
> note that I did not modify this line of code, it is as it was prior to my
> changes!
>
> closing the stable door after the horse has bolted!m
Noted. But good to clean up whilst making significant code changes. Thanks
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24085#discussion_r2020360775
