On Fri, 28 Mar 2025 05:39:27 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Larry Cable has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Merge branch 'JDK-8344671' of github.com:larry-cable/jdk into JDK-8344671
>> - JDK-8344671: removed JFR tests from problemlist resolved by this fix
>
> src/jdk.attach/macosx/native/libattach/VirtualMachineImpl.c line 148:
>
>> 146:
>> 147: if (caught && !ignored) {
>> 148: if (kill((pid_t)pid, SIGQUIT)) {
>
> Style nit: no implicit booleans
> Suggestion:
>
> if (kill((pid_t)pid, SIGQUIT) != 0) {
note that I did not modify this line of code, it is as it was prior to my
changes!
closing the stable door after the horse has bolted!m
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24085#discussion_r2019048154
