On Fri, 28 Mar 2025 06:09:53 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:
>> Larry Cable has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Merge branch 'JDK-8344671' of github.com:larry-cable/jdk into JDK-8344671
>> - JDK-8344671: removed JFR tests from problemlist resolved by this fix
>
> src/jdk.attach/macosx/native/libattach/VirtualMachineImpl.c line 140:
>
>> 138: if (sysctl(mib, sizeof(mib) / sizeof(int), &kiproc, &kipsz, NULL,
>> 0) == 0) {
>> 139: const bool ignored = (kiproc.kp_proc.p_sigignore &
>> sigmask(SIGQUIT)) != 0;
>> 140: const bool caught = (kiproc.kp_proc.p_sigcatch &
>> sigmask(SIGQUIT)) != 0;
>
> Nit: Past tense in mask bit value names is a little bit confusing here.
> Would it better to name them `ignore` and `catch` or `ignore_bit` and
> `catch_bit`?
"is SIGQUIT caught or ignored" ... I see no confusion here...
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24085#discussion_r2019045469
