On Fri, 23 May 2025 21:20:39 GMT, Johannes Bechberger <jbechber...@openjdk.org> wrote:
>> This is the code for the [JEP 509: CPU Time based profiling for >> JFR](https://openjdk.org/jeps/509). >> >> Currently tested using [this test >> suite](https://github.com/parttimenerd/basic-profiler-tests). This runs >> profiles the [Renaissance](https://renaissance.dev/) benchmark with >> - ... different heap sizes >> - ... different GCs >> - ... different samplers (the standard JFR and the new CPU Time Sampler and >> both) >> - ... different JFR recording durations >> - ... different chunk-sizes > > Johannes Bechberger has updated the pull request incrementally with one > additional commit since the last revision: > > Fix compilation src/hotspot/share/jfr/support/jfrThreadLocal.cpp line 564: > 562: } > 563: > 564: void JfrThreadLocal::set_has_cpu_time_jfr_requests(bool has_events) { "has_events" seems to be an unfortunate naming. "has_requests" I guess? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25302#discussion_r2106237580