On Sun, 25 May 2025 15:29:38 GMT, Markus Grönlund <mgron...@openjdk.org> wrote:
>> Johannes Bechberger has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix compilation
>
> src/hotspot/share/jfr/recorder/service/jfrEventThrottler.cpp line 118:
>
>> 116: bool JfrEventThrottler::accept(JfrEventId event_id, int64_t timestamp
>> /* 0 */) {
>> 117: JfrEventThrottler* const throttler = for_event(event_id);
>> 118: if (throttler == nullptr) {
>
> Unfortunately, two checks have been introduced on the throttler hot path. Can
> we avoid this in some way?
Can the settings system be updated so the throttle bit is not set in the native
settings struct?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25302#discussion_r2106235088
