On Fri, 23 May 2025 21:20:39 GMT, Johannes Bechberger <jbechber...@openjdk.org> wrote:
>> This is the code for the [JEP 509: CPU Time based profiling for >> JFR](https://openjdk.org/jeps/509). >> >> Currently tested using [this test >> suite](https://github.com/parttimenerd/basic-profiler-tests). This runs >> profiles the [Renaissance](https://renaissance.dev/) benchmark with >> - ... different heap sizes >> - ... different GCs >> - ... different samplers (the standard JFR and the new CPU Time Sampler and >> both) >> - ... different JFR recording durations >> - ... different chunk-sizes > > Johannes Bechberger has updated the pull request incrementally with one > additional commit since the last revision: > > Fix compilation src/hotspot/share/jfr/recorder/service/jfrEventThrottler.cpp line 118: > 116: bool JfrEventThrottler::accept(JfrEventId event_id, int64_t timestamp /* > 0 */) { > 117: JfrEventThrottler* const throttler = for_event(event_id); > 118: if (throttler == nullptr) { Unfortunately, two checks have been introduced on the throttler hot path. Can we avoid this in some way? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25302#discussion_r2106234319
