On Sun, 25 May 2025 10:14:14 GMT, Markus Grönlund <mgron...@openjdk.org> wrote:
>> Johannes Bechberger has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix compilation > > src/hotspot/share/jfr/periodic/sampling/jfrCPUTimeThreadSampler.cpp line 25: > >> 23: */ >> 24: >> 25: #include "gc/shared/barrierSet.hpp" > > Is this used / needed? Good catch > src/hotspot/share/jfr/periodic/sampling/jfrCPUTimeThreadSampler.cpp line 219: > >> 217: void stop_timer(); >> 218: >> 219: void trigger_out_of_safepoint_sampling(); > > What is "out of safepoint sampling"? See above ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25302#discussion_r2106811373 PR Review Comment: https://git.openjdk.org/jdk/pull/25302#discussion_r2106805944
