On Fri, 23 May 2025 21:20:39 GMT, Johannes Bechberger <jbechber...@openjdk.org> wrote:
>> This is the code for the [JEP 509: CPU Time based profiling for >> JFR](https://openjdk.org/jeps/509). >> >> Currently tested using [this test >> suite](https://github.com/parttimenerd/basic-profiler-tests). This runs >> profiles the [Renaissance](https://renaissance.dev/) benchmark with >> - ... different heap sizes >> - ... different GCs >> - ... different samplers (the standard JFR and the new CPU Time Sampler and >> both) >> - ... different JFR recording durations >> - ... different chunk-sizes > > Johannes Bechberger has updated the pull request incrementally with one > additional commit since the last revision: > > Fix compilation src/hotspot/share/jfr/periodic/sampling/jfrCPUTimeThreadSampler.cpp line 65: > 63: Thread* raw_thread = Thread::current_or_null_safe(); > 64: JavaThread* jt; > 65: if (raw_thread == nullptr || !raw_thread->is_Java_thread()) { // this > can happen due to the high level of parralelism Is "!raw_thread->is_Java_thread()" even possible, if a timer is only associated with a JavaThread, and a thread deletes its timer before it destroys itself? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25302#discussion_r2106225024
