On Sun, 25 May 2025 14:54:13 GMT, Markus Grönlund <mgron...@openjdk.org> wrote:
>> Johannes Bechberger has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix compilation
>
> src/hotspot/share/jfr/periodic/sampling/jfrCPUTimeThreadSampler.cpp line 65:
>
>> 63: Thread* raw_thread = Thread::current_or_null_safe();
>> 64: JavaThread* jt;
>> 65: if (raw_thread == nullptr || !raw_thread->is_Java_thread()) { // this
>> can happen due to the high level of parralelism
>
> Is "!raw_thread->is_Java_thread()" even possible, if a timer is only
> associated with a JavaThread, and a thread deletes its timer before it
> destroys itself?
Also, is raw_thread == nullptr even possible? For the same reasons.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25302#discussion_r2106295956
