On Sat, 31 Jan 2026 01:15:57 GMT, Yasumasa Suenaga <[email protected]> wrote:
>> TestJhsdbJstackMixedCore.java introduced in >> [JDK-8374482](https://bugs.openjdk.org/browse/JDK-8374482) failed on Alpine >> because musl-c does not provide the symbol of signal trampoline >> (`__restore_rt` on Linux Kernel for AMD64) as following: >> >> >> java.lang.RuntimeException: '<signal handler called>' missing from >> stdout/stderr >> at jdk.test.lib.process.OutputAnalyzer.shouldContain(OutputAnalyzer.java:253) >> at TestJhsdbJstackMixedCore.runJstackMixed(TestJhsdbJstackMixedCore.java:62) >> at TestJhsdbJstackMixedCore.main(TestJhsdbJstackMixedCore.java:74) >> at >> java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104) >> at java.base/java.lang.reflect.Method.invoke(Method.java:565) >> at >> com.sun.javatest.regtest.agent.MainActionHelper$AgentVMRunnable.run(MainActionHelper.java:335) >> at java.base/java.lang.Thread.run(Thread.java:1516) >> >> >> It would success if debuginfo is installed, but it should be skipped if the >> symbol is not available. >> See JBS for details. > > Yasumasa Suenaga has updated the pull request incrementally with one > additional commit since the last revision: > > Clarify comments regarding debuginfo retrieval test/hotspot/jtreg/serviceability/sa/TestJhsdbJstackMixedCore.java line 72: > 70: var libc = SATestUtils.getLibCPath(); > 71: if (!SATestUtils.isSymbolAvailable(libc, "__restore_rt")) { > 72: throw new SkippedException("Signal trampoline (__restore_rt) > not found in libc."); I think you should clarify with a comment here that the presence of the __restore_rt trampoline is what triggers SA to generate the frame with the name "<signal handler called>", and if the __restore_rt symbol does not exist, then SA will not know to call the frame "<signal handler called>". ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29480#discussion_r2755834642
