On Mon, 2 Feb 2026 19:43:05 GMT, Chris Plummer <[email protected]> wrote:
>> test/hotspot/jtreg/serviceability/sa/TestJhsdbJstackMixedCore.java line 72:
>>
>>> 70: var libc = SATestUtils.getLibCPath();
>>> 71: if (!SATestUtils.isSymbolAvailable(libc, "__restore_rt")) {
>>> 72: throw new SkippedException("Signal trampoline
>>> (__restore_rt) not found in libc.");
>>
>> I think you should clarify with a comment here that the presence of the
>> __restore_rt trampoline is what triggers SA to generate the frame with the
>> name "`<signal handler called>`", and if the __restore_rt symbol does not
>> exist, then SA will not know to call the frame "`<signal handler called>`".
>
> ...and maybe SA should generate the frame as "__restore_rt <signal handler
> called\>" or "__restore_rt <signal handler trampoline\>".
I updated to show `__restore_rt <signal trampoline>` for signal trampoline, and
also I added comments for it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29480#discussion_r2756571945
