On Mon, 2 Feb 2026 19:11:41 GMT, Chris Plummer <[email protected]> wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Clarify comments regarding debuginfo retrieval
>
> test/hotspot/jtreg/serviceability/sa/TestJhsdbJstackMixedCore.java line 72:
>
>> 70: var libc = SATestUtils.getLibCPath();
>> 71: if (!SATestUtils.isSymbolAvailable(libc, "__restore_rt")) {
>> 72: throw new SkippedException("Signal trampoline (__restore_rt)
>> not found in libc.");
>
> I think you should clarify with a comment here that the presence of the
> __restore_rt trampoline is what triggers SA to generate the frame with the
> name "`<signal handler called>`", and if the __restore_rt symbol does not
> exist, then SA will not know to call the frame "`<signal handler called>`".
...and maybe SA should generate the frame as "__restore_rt <signal handler
called\>" or "__restore_rt <signal handler trampoline\>".
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29480#discussion_r2755914781
