On Sat, 2 May 2026 09:40:50 GMT, Yasumasa Suenaga <[email protected]> wrote:
>> Kevin Walls has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> os classes simplification
>
> src/hotspot/share/runtime/thread.cpp line 617:
>
>> 615: #ifdef _WINDOWS
>> 616: os::win32::revive_init();
>> 617: #endif
>
> I think it is better to throw fatal error explicitly on unsupported platforms
> as following.
>
> Suggestion:
>
> #ifdef LINUX
> os::Linux::revive_init();
> #elif defined _WINDOWS
> os::win32::revive_init();
> #else
> fatal("revival mode is not supported on this platform");
> #endif
Thanks, I've removed the no-op methods in the os classes, only Linux requires
it right now. Now there is one ifdef for a Linux specific revive_init method,
and I've added a fatal() error in case this somehow gets calls on another
platform.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31011#discussion_r3207637880
