On Sat, 2 May 2026 10:55:21 GMT, Yasumasa Suenaga <[email protected]> wrote:
>> Kevin Walls has updated the pull request incrementally with one additional >> commit since the last revision: >> >> only use _s_vm_release_global, no need to use mangled version on Linux > > src/jdk.attach/share/native/revivalhelper/revival.hpp line 84: > >> 82: #define PATH_SEPARATOR ":" >> 83: >> 84: #define SYM_VM_RELEASE "_ZN19Abstract_VM_Version13_s_vm_releaseE" > > This symbol does not seem to be exposed, thus it is better to find it in > debuginfo if possible like SA. I do see it exposed on Linux, not Windows. So I added the "_s_vm_release_global" for Windows. We may as well use this symbol on Linux as well, and not use the above mangled definition. Generally we don't want to require any debuginfo here, a regular product install should be able to run jcmd on cores without adding debuginfo. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31011#discussion_r3208287527
