On Sat, 2 May 2026 10:05:49 GMT, Yasumasa Suenaga <[email protected]> wrote:
>> Kevin Walls has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> VirtualMachine api doc update
>
> src/jdk.attach/share/classes/sun/tools/attach/VirtualMachineCoreDumpImpl.java
> line 142:
>
>> 140:
>> 141: // Invoke "JDK/lib/revivalhelper corefilename jcmd command..."
>> 142: String jdkLibDir = System.getProperty("java.home") +
>> File.separator + "lib";
>
> It might be simple as following:
> Suggestion:
>
> String jdkLibDir = Path.of(System.getProperty("java.home"),
> "lib").toString();
Yes sure.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31011#discussion_r3209574773
