On Fri, 8 May 2026 11:25:16 GMT, Kevin Walls <[email protected]> wrote:
>> This implements "jcmd on core files" for Linux, and for MiniDumps on Windows >> (MacOS is "future work"). >> jcmd "revives" the VM memory and .so/.dll from the core/minidump, and runs >> the existing native diagnostic command parser and command implementations. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Kevin Walls has updated the pull request incrementally with one additional > commit since the last revision: > > only use _s_vm_release_global, no need to use mangled version on Linux src/jdk.attach/share/classes/com/sun/tools/attach/VirtualMachine.java line 191: > 189: public static VirtualMachine attach(String id) > 190: throws AttachNotSupportedException, IOException > 191: { Need to decide if this should be replaced with `attach(id, Map.of())`. src/jdk.attach/share/classes/com/sun/tools/attach/VirtualMachine.java line 235: > 233: * > 234: * @param env > 235: * A Map of provider-specific settings to configure the > attach. Add ", can be empty". src/jdk.attach/share/classes/com/sun/tools/attach/VirtualMachine.java line 263: > 261: * <td>Directory path of where to search for shared libraries when > initially reading a core file. > 262: * This may be a list of multiple directories, separated by > File.pathSeparator. > 263: * Required when files are transported between machines, or > libraries at locations in the dump "This property is required when ..." src/jdk.attach/share/classes/com/sun/tools/attach/spi/AttachProvider.java line 163: > 161: * > 162: * @param env > 163: * A Map of provider-specific settings to configure the > attach. Add ", can be empty". ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31011#discussion_r3208972220 PR Review Comment: https://git.openjdk.org/jdk/pull/31011#discussion_r3208974608 PR Review Comment: https://git.openjdk.org/jdk/pull/31011#discussion_r3208989335 PR Review Comment: https://git.openjdk.org/jdk/pull/31011#discussion_r3208957674
