On Wed, 22 Jul 2026 02:00:23 GMT, David Holmes <[email protected]> wrote:
>> Before posting the VM_DEATH event the JVMTI code spins for up to 60 seconds >> to allow in-progress callbacks to complete. If one of those callbacks >> requires a safepoint while executing, then it will not be able to attain it >> until the 60s spin is over - thus causing an apparent "hang" at VM >> termination. The simple fix is to insert a `ThreadBlockInVM` in the loop so >> that safepoint requests are honored. >> >> Testing: >> - tiers 1-5 >> - new regression test >> >> Thanks. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > David Holmes has updated the pull request incrementally with one additional > commit since the last revision: > > reword comment for clarity Marked as reviewed by lmesnik (Reviewer). test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/TransformerShutdownDeadlockTest.java line 32: > 30: * @library /test/lib > 31: * @modules java.instrument > 32: * @compile TransformerShutdownDeadlockTest.java I don't think the explicit compilation is needed here. Test should be compiled automatically. ------------- PR Review: https://git.openjdk.org/jdk/pull/31982#pullrequestreview-4758619761 PR Review Comment: https://git.openjdk.org/jdk/pull/31982#discussion_r3633680225
