On Wed, 22 Jul 2026 20:49:24 GMT, Leonid Mesnik <[email protected]> wrote:
>> David Holmes has updated the pull request incrementally with one additional >> commit since the last revision: >> >> reword comment for clarity > > Marked as reviewed by lmesnik (Reviewer). Thanks for the review @lmesnik . Obviously there are discussions that can be had about whether the current spec is reasonable, and if not what it might say, but that is a discussion for another place, not this PR. Here we are simply addressing the lack of safepoint checks within the existing code. > test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/TransformerShutdownDeadlockTest.java > line 32: > >> 30: * @library /test/lib >> 31: * @modules java.instrument >> 32: * @compile TransformerShutdownDeadlockTest.java > > I don't think the explicit compilation is needed here. Test should be > compiled automatically. Fixed. I used the sibling test in that directory as the template. ------------- PR Comment: https://git.openjdk.org/jdk/pull/31982#issuecomment-5052925319 PR Review Comment: https://git.openjdk.org/jdk/pull/31982#discussion_r3634754310
