On Thu, 23 Jul 2026 04:39:53 GMT, Serguei Spitsyn <[email protected]> wrote:
>> David Holmes has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove unnecessary @compile
>
> This looks good. Thank you for taking care about it!
> I've posted a couple of nits for new test.
Thanks for the review @sspitsyn ! All nits addressed.
> test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/TransformerShutdownDeadlockTest.java
> line 57:
>
>> 55:
>> TransformerShutdownDeadlockTest.Agent.class.getName() + "\n"
>> 56: + "Can-Retransform-Classes: true\n"
>> 57: + "Can-Retransform-Classes: true\n";
>
> Nit: The manifest property is set twice. Should one of them be:
> "Can-Redefine-Classes: true\n" ?
Copied from the other test. I deleted one - the test doesn't need redefinition.
> test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/TransformerShutdownDeadlockTest.java
> line 59:
>
>> 57: + "Can-Retransform-Classes: true\n";
>> 58:
>> 59: private static String CP = System.getProperty("test.classes");
>
> Nit: The `CP` is unused, so the line can be removed.
Again copied from other test <sigh>. Deleted
> test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/TransformerShutdownDeadlockTest.java
> line 155:
>
>> 153: t.start();
>> 154:
>> 155: while(!transform_running); // Wait for transform to start
>
> Nit: Space is missed after `while` at lines: 121 and 155.
Fixed
-------------
PR Comment: https://git.openjdk.org/jdk/pull/31982#issuecomment-5054992390
PR Review Comment: https://git.openjdk.org/jdk/pull/31982#discussion_r3635877431
PR Review Comment: https://git.openjdk.org/jdk/pull/31982#discussion_r3635879282
PR Review Comment: https://git.openjdk.org/jdk/pull/31982#discussion_r3635879866
