On Thu, 23 Jul 2026 12:34:57 GMT, Coleen Phillimore <[email protected]> wrote:

>> Please review this change that moves the Throwable and StackTrace classes 
>> into a new file.  I didn't make any modifications to the code, just moved 
>> it, added include directives to javaStackTraceClasses.hpp, minimized include 
>> directives in the new files, and removed includes in javaClasses.cpp that 
>> were no longer needed.
>> 
>> Tested with tier1 on Oracle supported platforms (product & fastdebug).
>> 
>> This change to be merged post valhalla integration.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Coleen Phillimore has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Add forward declarations, fix MAX_VERSION that fails with product compiles

Thank you for reviewing this Serguei.  I've made a couple of small updates and 
added the product build compilation fix that I forgot to push.

-------------

PR Review: https://git.openjdk.org/jdk/pull/32016#pullrequestreview-4763961956

Reply via email to