On Thu, 23 Jul 2026 05:05:29 GMT, Serguei Spitsyn <[email protected]> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add forward declarations, fix MAX_VERSION that fails with product compiles > > src/hotspot/share/classfile/javaClasses.hpp line 699: > >> 697: static void java_printStackTrace(Handle throwable, TRAPS); >> 698: // Debugging >> 699: friend class JavaClasses; > > Q: The lines 698-699 were not copied to new header. Is it intentional? Yes, it was intentional for some transient compilation failure I had. They don't need to be friends, but now I see they all are friends. I don't know why this is here so I've restored it. I'll investigate this later. > src/hotspot/share/classfile/javaStackTraceClasses.hpp line 230: > >> 228: #undef CHECK_INIT >> 229: >> 230: #endif // SHARE_CLASSFILE_JAVASTACKTRACECLASSES_HPP > > Nit: This header does not have forward declarations for: > - `Method`, `InstanceKlass`, `JavaThread`, and `outputStream`. > This can be a pre-existed issue in `javaClasses.hpp`. Yes, they are transiently included with other things probably because javaClasses.hpp is mostly included where this is included, but it's good to have the forward declarations. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32016#discussion_r3638018583 PR Review Comment: https://git.openjdk.org/jdk/pull/32016#discussion_r3638057956
