On Thu, 23 Jul 2026 12:21:00 GMT, Coleen Phillimore <[email protected]> wrote:
>> src/hotspot/share/classfile/javaClasses.hpp line 699: >> >>> 697: static void java_printStackTrace(Handle throwable, TRAPS); >>> 698: // Debugging >>> 699: friend class JavaClasses; >> >> Q: The lines 698-699 were not copied to new header. Is it intentional? > > Yes, it was intentional for some transient compilation failure I had. They > don't need to be friends, but now I see they all are friends. I don't know > why this is here so I've restored it. I'll investigate this later. It's not for debugging now. It's because compute_offsets() is private in many of the classes in javaClasses and only JavaClasses is the class that should call it. There must be a better way to do this. Some classes have compute_offsets() public, which is why they don't need the friend declaration. It may have been for debugging once when offsets were hard coded before the injection code was added, and compute_offsets was called for verification. I should remove "Debugging" comment from this PR in the new file. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32016#discussion_r3638198384
