On Wed, 12 Aug 2026 19:52:13 GMT, Chris Plummer <[email protected]> wrote:

>> Yasumasa Suenaga has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Improve OopField::getOffset
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/Inline.java line 47:
> 
>> 45:         // TODO
>> 46:         //Type type = db.lookupType("inlineOopDesc");
>> 47:     }
> 
> Why is this not implemented?
> 
> EDIT: I think this stems from my comment below on how this class is not 
> actually a mirror for inlineOop.

I added this class to intend to be a mirror for `inlineOop`, but there are no 
fields imported (so far) by HotSpot. Thus I added this comment not to forget to 
modify the code when it needs.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/32310#discussion_r3771554688

Reply via email to