On Mon, 24 Aug 2026 15:10:42 GMT, Coleen Phillimore <[email protected]> wrote:
>> Old jdi debugee classes keep their own verbose flag and only print their >> trace when the debugger passes -vbs. logs you cannot see until a rerun are >> useless for failures that do not reproduce, so the gating goes and the >> messages always print. 65 files here, the flag and its -vbs parsing are >> deleted and the little print helper becomes an unconditional display on >> stderr. two debugger classes carried a flag that nothing ever set, that dead >> code is just removed. the remaining files with the same pattern overlap open >> reviews and follow separately. output volume is a handful of lines per >> debugee. >> >> PS: Checked log size against a full nsk/jdi in CI run and none of the >> changed tests hit the jtreg output limit. Largest .jtr was about 100 KB, and >> this change adds only around a dozen short protocol lines per debuggee. The >> tests that do trip the overflow marker are the monitor and stress event >> tests. which aren’t modified here and were already doing so before this >> change. >> >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/name/name002a.java line > 60: > >> 58: try { >> 59: classUnloader.loadClass(checked_class_name, >> checked_class_dir); >> 60: display > > Can you make some of these one line? I'd suggest to make them all one-liners (unless the message is not very long). It impacts many files: - test/hotspot/jtreg/vmTestbase/nsk/jdi/ClassObjectReference/reflectedType/reflectype002a.java - test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/allFields/allfields002a.java - test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/allFields/allfields003a.java - test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/allFields/allfields004a.java - test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/allMethods/allmethods001a.java - test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/allMethods/allmethods002a.java - test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/allMethods/allmethods003a.java - test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/equals/equals002a.java - test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/failedToInitialize/failedToInitialize001a.java - test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/failedToInitialize/failedtoinit002a.java - test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/fieldByName/fieldbyname002a.java - test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/fieldByName/fieldbyname003a.java - test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/fields/fields002a.java - test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/fields/fields003a.java - test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/hashCode/hashcode002a.java - test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/isAbstract/isabstract002a.java - test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/isInitialized/isinit002a.java - test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/isPrepared/isprepared002a.java - test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/isVerified/isverified002a.java - test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/methods/methods001a.java - test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/methods/methods002a.java - test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/methods/methods003a.java - test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/methodsByName_s/methbyname_s001a.java - test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/methodsByName_s/methbyname_s002a.java - test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/methodsByName_s/methbyname_s003a.java - test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/methodsByName_s/methbyname_s004a.java - test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/methodsByName_ss/methbyname_ss001a.java - test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/methodsByName_ss/methbyname_ss002a.java - test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/methodsByName_ss/methbyname_ss003a.java - test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/name/name002a.java - test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/sourceName/sourcename002a.java - test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/visibleFields/visibfield002a.java - test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/visibleFields/visibfield003a.java - test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/visibleFields/visibfield004a.java - test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/visibleMethods/visibmethod002a.java - test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/visibleMethods/visibmethod003a.java - test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/visibleMethods/visibmethod005a.java This issue is pre-existed though. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32375#discussion_r3845972050
