On Mon, 24 Aug 2026 17:40:33 GMT, Serguei Spitsyn <[email protected]> wrote:
>> test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/name/name002a.java line
>> 60:
>>
>>> 58: try {
>>> 59: classUnloader.loadClass(checked_class_name,
>>> checked_class_dir);
>>> 60: display
>>
>> Can you make some of these one line?
>
> I'd suggest to make them all one-liners (unless the message is not very long).
> It impacts many files:
> -
> test/hotspot/jtreg/vmTestbase/nsk/jdi/ClassObjectReference/reflectedType/reflectype002a.java
> -
> test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/allFields/allfields002a.java
> -
> test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/allFields/allfields003a.java
> -
> test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/allFields/allfields004a.java
> -
> test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/allMethods/allmethods001a.java
> -
> test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/allMethods/allmethods002a.java
> -
> test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/allMethods/allmethods003a.java
> - test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/equals/equals002a.java
> -
> test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/failedToInitialize/failedToInitialize001a.java
> -
> test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/failedToInitialize/failedtoinit002a.java
> -
> test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/fieldByName/fieldbyname002a.java
> -
> test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/fieldByName/fieldbyname003a.java
> - test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/fields/fields002a.java
> - test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/fields/fields003a.java
> -
> test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/hashCode/hashcode002a.java
> -
> test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/isAbstract/isabstract002a.java
> -
> test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/isInitialized/isinit002a.java
> -
> test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/isPrepared/isprepared002a.java
> -
> test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/isVerified/isverified002a.java
> -
> test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/methods/methods001a.java
> -
> test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/methods/methods002a.java
> -
> test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/methods/methods003a.java
> -
> test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/methodsByName_s/methbyname_s001a.java
> -
> test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/methodsByName_s/methbyname_s002a.java
> -
> test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/methodsByName_s/methbyname_s003a.java
> -
> test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/methodsByName_s/methbyname_s004a.java
> -
> test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/methodsByName_ss/methbyname_ss001a.java
> - test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceTy...
made them one liners across all the files in this change, the rename to
log.display joined them. The ones outside this pr are a bigger pre existing
set, planning to handle those in a follow up
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32375#discussion_r3848283078
