On Tue, 25 Aug 2026 14:59:08 GMT, Shiv Shah <[email protected]> wrote:
>> Old jdi debugee classes keep their own verbose flag and only print their >> trace when the debugger passes -vbs. logs you cannot see until a rerun are >> useless for failures that do not reproduce, so the gating goes and the >> messages always print. 65 files here, the flag and its -vbs parsing are >> deleted and the little print helper becomes an unconditional display on >> stderr. two debugger classes carried a flag that nothing ever set, that dead >> code is just removed. the remaining files with the same pattern overlap open >> reviews and follow separately. output volume is a handful of lines per >> debugee. >> >> PS: Checked log size against a full nsk/jdi in CI run and none of the >> changed tests hit the jtreg output limit. Largest .jtr was about 100 KB, and >> this change adds only around a dozen short protocol lines per debuggee. The >> tests that do trip the overflow marker are the monitor and stress event >> tests. which aren’t modified here and were already doing so before this >> change. >> >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Shiv Shah has updated the pull request incrementally with one additional > commit since the last revision: > > Remove the verbose launcher flag and the vbs binder conditional Thank you for update. Looks good. ------------- Marked as reviewed by sspitsyn (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/32375#pullrequestreview-5025360205
