On Wed, 26 Aug 2026 18:17:28 GMT, Stefan Karlsson <[email protected]> wrote:
>> Axel Boldt-Christmas has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update Inline type identity hash comment
>
> src/hotspot/share/oops/oop.inline.hpp line 407:
>
>> 405: }
>> 406:
>> 407: intptr_t oopDesc::identity_hash(Thread* current) {
>
> Pre-existing: It is only the slow-path that makes sure that this isn't called
> for value objects. Should we check it in the fast-path as well?
I think we might want to try and make these separate. We have a couple of
places I think which does not guard agains value objects, but guard against the
slow-path (`has_identity_hash`). There might be a nicer interface we can come
up with here which makes the invariants clearer at the call site.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32535#discussion_r3869410992
