On Wed, 26 Aug 2026 18:27:49 GMT, Stefan Karlsson <[email protected]> wrote:
>> Axel Boldt-Christmas has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update Inline type identity hash comment
>
> src/hotspot/share/cds/aotMappedHeapWriter.cpp line 750:
>
>> 748: fake_oop->set_mark(fake_oop->mark().copy_set_hash(src_hash));
>> 749: } else if (Arguments::is_valhalla_enabled()) {
>> 750:
>> fake_oop->set_mark(src_klass->prototype_header().copy_set_hash(src_hash));
>
> BTW, what is this code all about? Here we know that Valhalla is enabled and
> that the object is not a value object, so why do we need to use the
> `prototype_header()` for this? Maybe something to look into outside this PR.
@iklam , I agree with Stefan, this looks wrong. What do you think?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32535#discussion_r3869867988
