On Tue, 6 Oct 2026 22:19:48 GMT, Chris Plummer <[email protected]> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> add a testcase with JVMTI_HEAP_FILTER_CLASS_UNTAGGED > > test/hotspot/jtreg/serviceability/jvmti/valhalla/Heapwalking/libFlatClassFilterTest.cpp > line 54: > >> 52: callbacks.heap_iteration_callback = heap_iteration; >> 53: >> 54: err = jvmti->IterateThroughHeap(0, filter, &callbacks, nullptr); > > Have you considered increasing test coverage by also testing with > JVMTI_HEAP_FILTER_CLASS_UNTAGGED in a separate test case? Good suggestion, thanks. Added a separate test case. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33172#discussion_r4201708458
