On Wed, 7 Oct 2026 02:38:43 GMT, Chris Plummer <[email protected]> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> add a testcase with JVMTI_HEAP_FILTER_CLASS_UNTAGGED
>
> test/hotspot/jtreg/serviceability/jvmti/valhalla/Heapwalking/libFlatClassFilterTest.cpp
> line 66:
>
>> 64: return JNI_ERR;
>> 65: }
>> 66: if (options != nullptr && strcmp(options,
>> "heap_filter_class_untagged") == 0) {
>
> You should probably return a JNI error if the strcmp fails. Otherwise if
> there is an error in the arg passing or matching, you just end up doing the
> first test case again.
Thanks. Fixed now.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/33172#discussion_r4209648548
