On Sat, 10 Oct 2026 02:51:12 GMT, Leonid Mesnik <[email protected]> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> add more checks and logs
>
> test/hotspot/jtreg/serviceability/jvmti/valhalla/Heapwalking/FlatClassFilterTest.java
> line 132:
>
>> 130: throw new AssertionError("The array is expected to be
>> flat");
>> 131: }
>> 132: if (filtered != all) {
>
> I think it would be make sense to add sanity check that 'all' > 30. Just to
> ensure that not all Value classes are skipped.
Thank you for the suggestion. But I'm not sure where did you get this.
The normal test log is:
FlatClassFilterTest: Started
v1 is flat: true
array is flat: true
all: 21
filtered: 21
FlatClassFilterTest: PASSED
So, `all` is equal to 21.
The invariant is just that `all == filtered`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/33172#discussion_r4237216713
