On Wed, 7 Oct 2026 17:07:43 GMT, Serguei Spitsyn <[email protected]> wrote:
>> When the JVMTI `IterateThroughHeap` has a class filter then the flattened >> value objects contained in the fields of filtered class objects are not >> reported. The fix is: >> - If the object has flattened fields, visit and report them as heap objects >> even though this object was not reported. >> >> The update adds new test with a needed coverage: >> >> `test/hotspot/jtreg/serviceability/jvmti/valhalla/Heapwalking/FlatClassFilterTest.java` >> >> Testing: >> - check new test is failing without fix and is passing with the fix >> - TBD: run mach5 tiers 1-6 >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Serguei Spitsyn has updated the pull request incrementally with one > additional commit since the last revision: > > add more checks and logs Skara does not allow to integrate changes with two reviews. What is the hell this Skara message: "No applicable reviews submitted by reviewers with write permissions? How can this be fixed? Why Skara is so unclear what it really does not like? Also, why approvals from Leonid and Dan are listed as with read-only permissions? What does it mean? ------------- PR Comment: https://git.openjdk.org/jdk/pull/33172#issuecomment-6106599031 PR Comment: https://git.openjdk.org/jdk/pull/33172#issuecomment-6106624957
