On Thu, 15 Oct 2026 22:09:19 GMT, Chris Plummer <[email protected]> wrote:

>> Yasumasa Suenaga has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Skip tests on musl c on AArch64
>
> src/jdk.hotspot.agent/linux/native/libsaproc/dwarf.cpp line 412:
> 
>> 410:         free(_lib->frame.data);
>> 411:       }
>> 412:       memcpy(&_lib->frame, &frame, sizeof(frame_info));
> 
> You are freeing and replacing the .eh_frame with the .debug_frame, which 
> means a subsequent parse won't have access to the .eh_frame and will always 
> defer to the .debug_frame.

Yes, it is intended because this change assumes `.debug_frame` is enough to 
unwind frames if it is available.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/33375#discussion_r4289185735

Reply via email to