On Thu, 15 Oct 2026 23:09:17 GMT, Yasumasa Suenaga <[email protected]> wrote:

>> src/jdk.hotspot.agent/linux/native/libsaproc/dwarf.cpp line 412:
>> 
>>> 410:         free(_lib->frame.data);
>>> 411:       }
>>> 412:       memcpy(&_lib->frame, &frame, sizeof(frame_info));
>> 
>> You are freeing and replacing the .eh_frame with the .debug_frame, which 
>> means a subsequent parse won't have access to the .eh_frame and will always 
>> defer to the .debug_frame.
>
> Yes, it is intended because this change assumes `.debug_frame` is enough to 
> unwind frames if it is available.

Theoretically you could have an address that is covered by the .debug_frame but 
not the .eh_frame, and another address covered by the .eh_frame but not the 
.debug_frame. If you don't think this is possible with how the JDK is built, 
then I guess we don't need to worry about that happening.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/33375#discussion_r4289340826

Reply via email to