On Thu, 15 Oct 2026 22:10:43 GMT, Chris Plummer <[email protected]> wrote:

>> Yasumasa Suenaga has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Skip tests on musl c on AArch64
>
> src/jdk.hotspot.agent/linux/native/libsaproc/libproc_impl.c line 298:
> 
>> 296:    if (fill_addr_info(newlib)) {
>> 297:      if (!read_frame(".eh_frame", newlib->fd, &newlib->frame)) {
>> 298:        print_debug("Could not find .eh_frame section in %s\n", 
>> newlib->name);
> 
> Do we want to support the use case where there is no .eh_frame but there is a 
> .debug_frame?

It seems to be a special case, so I think we don't need to consider it.

In GCC 16.2.1, we can create `.debug_frame` only ELF with `-g 
-fno-asynchronous-unwind-tables -c`, However `.eh_frame` would appear when the 
object file is linked. Hence ELF without `.eh_frame` could be created, but very 
special.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/33375#discussion_r4289278431

Reply via email to