On Mon, 19 Oct 2026 18:21:54 GMT, Xin Liu <[email protected]> wrote: >> Andrei Pangin has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains two commits: >> >> - Re-implemented native frames support using variable-size requests >> - 8392187: JFR: Use-after-free bug in CPU-time profiler can crash JVM > > src/hotspot/share/jfr/periodic/sampling/jfrThreadSampling.cpp line 341: > >> 339: return; >> 340: } >> 341: traceid sid; > > we need to initialize sid = 0 here, or assert(sid != 0) at line 355 is > undefined.
`sid` is always initialized at line 353 before reaching `assert`. The same pattern has been already used in other places. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32524#discussion_r4320368387
