On Tue, 20 Oct 2026 00:49:57 GMT, Andrei Pangin <[email protected]> wrote:
>> src/hotspot/share/jfr/periodic/sampling/jfrThreadSampling.cpp line 341: >> >>> 339: return; >>> 340: } >>> 341: traceid sid; >> >> we need to initialize sid = 0 here, or assert(sid != 0) at line 355 is >> undefined. > > `sid` is always initialized at line 353 before reaching `assert`. > The same pattern has been already used in other places. feel free to resolve those comments. I can't resolve them. I agree with your comments. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32524#discussion_r4340522184
