On Mon, 19 Oct 2026 22:23:56 GMT, Xin Liu <[email protected]> wrote: >> Andrei Pangin has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains two additional >> commits since the last revision: >> >> - Re-implemented native frames support using variable-size requests >> - 8392187: JFR: Use-after-free bug in CPU-time profiler can crash JVM > > src/hotspot/share/jfr/periodic/sampling/jfrCPUTimeThreadSampler.cpp line 617: > >> 615: break; // reached generated Java code >> 616: } >> 617: pcs[count++] = pc; > > should we put this assignment after the sanity check at line 619?
No, `pc` is valid at this point. The following `fp` check verifies if we can continue stack walking, i.e. if we can obtain next `pc` reliably, not the current one. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32524#discussion_r4320583953
