On Thu, 22 Oct 2026 03:38:56 GMT, Fei Yang <[email protected]> wrote:
>> Long Yang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Enable TestJhsdbJstackMixedWithXComp.java on riscv64 while excluding QEMU
>> environments
>
> src/jdk.hotspot.agent/linux/native/libsaproc/dwarf.cpp line 146:
>
>> 144: std::stack<struct DwarfState> remember_state;
>> 145:
>> 146: while ((_buf < end) && (_current_pc <= pc)) {
>
> Small question: What is this change for? I didn't see any discussion or
> explanatory comment about this. I wonder how this may affect other CPU
> platforms, like x86/aarch64.
I agree with this change because this function
(`DwarfParser::parse_dwarf_instructions()`) proceeds CFI instruction to the PC
what we want to see. `_current_pc` which represents PC in CFI should be
proceeded even if it equals with `pc`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/33374#discussion_r4355262476
