On Fri, 23 Oct 2026 01:33:55 GMT, Yasumasa Suenaga <[email protected]> wrote:

>> src/jdk.hotspot.agent/linux/native/libsaproc/dwarf.cpp line 146:
>> 
>>> 144:   std::stack<struct DwarfState> remember_state;
>>> 145: 
>>> 146:   while ((_buf < end) && (_current_pc <= pc)) {
>> 
>> Small question: What is this change for? I didn't see any discussion or 
>> explanatory comment about this. I wonder how this may affect other CPU 
>> platforms, like x86/aarch64.
>
> I agree with this change because this function 
> (`DwarfParser::parse_dwarf_instructions()`) proceeds CFI instruction to the 
> PC what we want to see. `_current_pc` which represents PC in CFI should be 
> proceeded even if it equals with `pc`.

I will approve this change when the confliction is resolved.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/33374#discussion_r4355265235

Reply via email to