On Tue, 3 Nov 2026 00:32:08 GMT, Serguei Spitsyn <[email protected]> wrote:
>> Shiv Shah has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Drop the virtual argument, the frame count already tells
>
> test/hotspot/jtreg/serviceability/AsyncGetCallTrace/libAsyncGetCallTraceTest.cpp
> line 207:
>
>> 205:
>> 206: JNIEXPORT jboolean JNICALL
>> 207: Java_MyPackage_ASGCTBaseTest_checkAsyncGetCallTraceCall(JNIEnv* env,
>> jclass cls, jboolean is_virtual) {
>
> There is no need in this extra boolean argument. There are other ways to
> identify thread as virtual, e.g.:
> - `trace.num_frames > gstCount`
> - `env->IsVirtualThread(thread)`
Dropped it. The frame count decides now, a platform thread with extra frames
still fails on the enterSpecial check of the frame after
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/33617#discussion_r4459929638
