On Fri, 13 Nov 2026 23:52:59 GMT, Leonid Mesnik <[email protected]> wrote:
>> Shiv Shah has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains four additional commits >> since the last revision: >> >> - Split into a platform and a virtual test case >> - Merge remote-tracking branch 'upstream/master' into JDK-8308026 >> - Drop the virtual argument, the frame count already tells >> - 8308026: AsyncGetCallTraceTest fails with virtual threads > > test/hotspot/jtreg/serviceability/AsyncGetCallTrace/MyPackage/ASGCTBaseTest.java > line 40: > >> 38: /** >> 39: * @test id=virtual >> 40: * @summary Verifies that AsyncGetCallTrace is call-able and provides >> sane information. > > Second summary is not needed. Removed > test/hotspot/jtreg/serviceability/AsyncGetCallTrace/MyPackage/ASGCTBaseTest.java > line 41: > >> 39: * @test id=virtual >> 40: * @summary Verifies that AsyncGetCallTrace is call-able and provides >> sane information. >> 41: * @compile ASGCTBaseTest.java > > i think this line is not needed in both tests. Removed from both ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33617#discussion_r4589554023 PR Review Comment: https://git.openjdk.org/jdk/pull/33617#discussion_r4589556426
