On Tue, 3 Nov 2026 20:15:38 GMT, Shiv Shah <[email protected]> wrote: >> With the virtual thread factory main runs on a virtual thread and >> AsyncGetCallTrace keeps walking into the carrier, GetStackTrace stops at the >> continuation entry. So the two never had the same number of frames there. >> AsyncGetCallTrace itself is left alone, profilers build on what it returns >> today and the replacement API is its own effort. >> >> The test now runs the check on a platform thread and on a virtual thread it >> starts itself, whatever main runs on. Platform stays the exact comparison. >> On the virtual thread the GetStackTrace frames have to be a prefix of the >> AsyncGetCallTrace frames and the next frame has to be >> Continuation.enterSpecial. With -XX:-VMContinuations both lists are the same >> and that passes too. The virtual ProblemList entry is gone. >> >> --- >> >> Testing: >> - [x] The test five times on linux-x64 and linux-aarch64 debug with the >> platform factory, the virtual factory and -XX:-VMContinuations, plus tier1-3 >> on both >> >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Shiv Shah has updated the pull request incrementally with one additional > commit since the last revision: > > Drop the virtual argument, the frame count already tells
Changes requested by lmesnik (Reviewer). test/hotspot/jtreg/serviceability/AsyncGetCallTrace/MyPackage/ASGCTBaseTest.java line 29: > 27: /** > 28: * @test > 29: * @summary Verifies that AsyncGetCallTrace is call-able and provides > sane information on platform and virtual threads. It is needed to split test and add @requires vm.continuations to the testcase with virtual threads. Also, add @requires test.thread.factory == null to both test cases. No need to run any of them on the main virtual thread. ------------- PR Review: https://git.openjdk.org/jdk/pull/33617#pullrequestreview-5850117472 PR Review Comment: https://git.openjdk.org/jdk/pull/33617#discussion_r4531053512
