[
https://issues.apache.org/jira/browse/SHINDIG-864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12664278#action_12664278
]
Henning Schmiedehausen commented on SHINDIG-864:
------------------------------------------------
Paul,
you created this ticket and resolved it inside seven minutes. That is just
lip-service. If you don't plan to have any discussion on a patch but only open
and close the ticket to formally fulfill a "we track patches by tickets" rule,
then you can as well not do it and apply your patch directly.
- Is there any advantage right now that you need this new version for so an
update is justified?
- Did you test before applying? Did you see regressions?
- Did you consider doing a quick branch to test this out and allow others to
look at it and comment on the patch?
- Is there a code review somewhere?
This is another "hundreds of lines, dozens of classes" changes that you simply
push to the community without any discussion. And if a discussion is stirred
up, you basically ignore it, say "I am right, you are wrong" and go on.
Can we *please* change this modus operandi? Do you have any idea how hard it is
for anyone outside the immediate committer group to follow the code base and
the subtle changes that get committed with one liners like "clean things up a
bit" and get hidden in boilerplate "upgrade to newest version because it is
cool" commits.
- What was cleaned up?
- How was it cleaned up?
-What is the reason for the cleaning?
Again I'd like to urge you to consider backing this patch out and putting it on
an experimental branch first, so that others can test these changes in their
environments (And I don't mean me; I forked our internal code base off the 0.8
branch a while ago and I sporadically pull in changes from there. Trying to
work against trunk is more or less pointless ATM.
> Upgrade to XStream 1.3.1
> ------------------------
>
> Key: SHINDIG-864
> URL: https://issues.apache.org/jira/browse/SHINDIG-864
> Project: Shindig
> Issue Type: Improvement
> Components: RESTful API (Java)
> Affects Versions: trunk
> Reporter: Paul Lindner
> Assignee: Paul Lindner
> Fix For: trunk
>
>
> There are new features in XStream 1.3.1 that might make implementing the
> marshaling/demarshaling easier.
> http://xstream.codehaus.org/changes.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
