[
https://issues.apache.org/jira/browse/SHINDIG-864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12664316#action_12664316
]
Paul Lindner commented on SHINDIG-864:
--------------------------------------
Hmm, there was a caja update and refactoring of the jar structure recently too.
All very short lived patches. None of them were integrated into 1.0.x branch,
only trunk.
I'll accept your veto when you provide a technical justification that this code
is invalid. Since it appears you didn't even read the patch I'm going to let
it stand.
trunk is CTR until we as a group decide that it's not beneficial for the
community. For SPI/API changes and situations where I'm not comfortable
submitting a change I do post code reviews. (Also FWIW In all my time posting
code reviews no one has commented once.) This says to me that RTC will not
work on this project until we can get more reviewers...
As far as XStream 1.3.1 goes -->
* old version over 2 years old, yet mostly upwards compatible
* low risk upgrade
* benched on hi5 staging servers, on baseline performance curve
* new features available that can make it easier for people to hack on the
xstream code that we have. Right now it's very difficult for someone to jump
in there. (I know, I spent a bunch of hours there trying to figure out how all
of those classes are assembled.)
As far as cleanups go you should look at the patch, here's a file by file
roundup for your information:
Index:
java/social-api/src/test/java/org/apache/shindig/social/opensocial/util/BeanXStreamConverterTest.java
Index:
java/social-api/src/test/java/org/apache/shindig/social/opensocial/util/BeanXStreamAtomConverterTest.java
-- Add setUrl for activities to test cases.
This will become necessary if we want to support Atom in any reasonable way.
Index:
java/social-api/src/main/java/org/apache/shindig/social/core/util/xstream/PropertyDictionary.java
-- Unused class, was never needed for xstream functionality.
Index:
java/social-api/src/main/java/org/apache/shindig/social/core/util/xstream/RestfullCollectionConverter.java
-- minimal formatting changes, inline one boolean return
Index:
java/social-api/src/main/java/org/apache/shindig/social/core/util/xstream/XStream081Configuration.java
-- made this class almost readable. Before this was a bunch of maps and lists
that wouldn't look good on your 300 character wide monitor. Now it's actually
readable and somewhat understandable by using static constructor methods and
multimaps internally. Oh and a one-liner fix for xstream 1.3.1
Index:
java/social-api/src/main/java/org/apache/shindig/social/core/util/xstream/MapConverter.java
-- inline boolean, fix @see annotations
Index:
java/social-api/src/main/java/org/apache/shindig/social/core/util/xstream/NamespaceSet.java
--- Simplfy with Objects.firstNonNull()
Index:
java/social-api/src/main/java/org/apache/shindig/social/core/util/xstream/GuiceBeanConverter.java
-- imports cleanup
Index:
java/social-api/src/main/java/org/apache/shindig/social/core/util/xstream/DataCollectionConverter.java
-- inline boolean, remove if (false) code branch.
Index:
java/social-api/src/main/java/org/apache/shindig/social/core/util/xstream/StackDriver.java
-- fix @see annotations
Index:
java/social-api/src/main/java/org/apache/shindig/social/core/util/xstream/ClassFieldMapping.java
-- boolean simpliifications, javadoc.
Index:
java/social-api/src/main/java/org/apache/shindig/social/core/util/xstream/InterfaceClassMapper.java
multimaps
Index:
java/social-api/src/main/java/org/apache/shindig/social/core/util/atom/AtomSource.java
-- Insure that Atom URLs have a href for the moment.
Index:
java/social-api/src/main/java/org/apache/shindig/social/core/util/atom/AtomFeed.java
-- use immutablelist for single entry atom lists. (Served as a debugging aid
to find nulls getting passed around, and generally useful)
Index:
java/social-api/src/main/java/org/apache/shindig/social/core/util/atom/AtomLinkConverter.java
-- formatting, remove suppresswarnings annotation
Index:
java/social-api/src/main/java/org/apache/shindig/social/core/util/atom/AtomAttributeConverter.java
-- insure that no nulls are being passed in here.
Index:
java/social-api/src/main/java/org/apache/shindig/social/core/util/atom/AtomLink.java
-- include type/title elements so we can start supporting atom format properly.
Index:
java/social-api/src/main/java/org/apache/shindig/social/core/util/BeanXStreamAtomConverter.java
-- logic simplifications
Index: java/social-api/pom.xml
reference new xpp3_min lib
Index: java/common/src/main/java/org/apache/shindig/common/JsonSerializer.java
-- remove redundant <? extends Object> notations
Index:
java/common/src/main/java/org/apache/shindig/common/servlet/GuiceServletContextListener.java
-- boolean simplification
Index:
java/gadgets/src/main/java/org/apache/shindig/gadgets/http/AbstractHttpCache.java
-- boolean simplification
Index:
java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java
-- boolean simplifcation
Index: pom.xml
xpp3-1.1.3.3 --> xpp_min-1.1.4c
xstream 1.2 -> 1.3.1
I would hope that this satisfies you.
> Upgrade to XStream 1.3.1
> ------------------------
>
> Key: SHINDIG-864
> URL: https://issues.apache.org/jira/browse/SHINDIG-864
> Project: Shindig
> Issue Type: Improvement
> Components: RESTful API (Java)
> Affects Versions: trunk
> Reporter: Paul Lindner
> Assignee: Paul Lindner
> Fix For: trunk
>
>
> There are new features in XStream 1.3.1 that might make implementing the
> marshaling/demarshaling easier.
> http://xstream.codehaus.org/changes.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
