[
https://issues.apache.org/jira/browse/SHINDIG-864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12664471#action_12664471
]
Ian Boston commented on SHINDIG-864:
------------------------------------
When this commit came through I gave it a quick look. SInce Hennings comment I
have spent about 45 minutes on it giving it a more complete look. Having
written the XStream converter code for the Atom protocol in the first place I
believe the patch to be good and precise. I cant say its 100%, because nothing
is, but it is an improvement on my less than perfect code. There are some non
funcitonal changes including reformatting and javadoc corrections, but AFAICT
they all move the code base closer to the style guide than before.
There are 4 files outside the XStream scope in gadgets and commons, that make
very minor formatting changes, correcting simple mistakes, so although these
are not directly related to this patch they are also valid.
SO:
IMVHO, the changes that the patch introduces are good, and if I had spent 45
minutes when the commit came through I would have come to the same conclusion,
and perhaps even commented. I certainly would have shouted if any warning bells
were rung by the brief look that I did take at the time.
HTH
Ian
> Upgrade to XStream 1.3.1
> ------------------------
>
> Key: SHINDIG-864
> URL: https://issues.apache.org/jira/browse/SHINDIG-864
> Project: Shindig
> Issue Type: Improvement
> Components: RESTful API (Java)
> Affects Versions: trunk
> Reporter: Paul Lindner
> Assignee: Paul Lindner
> Fix For: trunk
>
>
> There are new features in XStream 1.3.1 that might make implementing the
> marshaling/demarshaling easier.
> http://xstream.codehaus.org/changes.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
