[
https://issues.apache.org/jira/browse/SHINDIG-864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667824#action_12667824
]
Henning Schmiedehausen commented on SHINDIG-864:
------------------------------------------------
Paul, I did not veto the patch. I was just concerned of a very large patch
without any clear documentation. From your list of changes, it is clear, that
these were actually a bunch of patches
- update to xstream 1.3.1
- code changes (e.g. AbstractHttpCache.java)
- formatting and doc changes (@see stuff)
- changes related to google collections
So I would have expected to get a bunch of clearly separated patches, which in
turn would have it made much easier to understand the changes and read the
patch (which I did, even though you assumed otherwise).
Throwing a bunch of eggs in one basket and then making a
one-line-comment-lump-commit might make sense in other environments; in open
source projects, where people outside the committer team might want to follow
progress and understand what happens, smaller commits with more comments are
IMHO more useful. As you are a seasoned open source contributor, I am sure that
you agree here.
If you are using local branches to develop stuff and have trouble separating
your patches out, I can recommend using a local git repository and syncing from
there to the SVN. I use this all the time and I know that this working style
has caught on with many other Apache committers.
> Upgrade to XStream 1.3.1
> ------------------------
>
> Key: SHINDIG-864
> URL: https://issues.apache.org/jira/browse/SHINDIG-864
> Project: Shindig
> Issue Type: Improvement
> Components: RESTful API (Java)
> Affects Versions: trunk
> Reporter: Paul Lindner
> Assignee: Paul Lindner
> Fix For: trunk
>
>
> There are new features in XStream 1.3.1 that might make implementing the
> marshaling/demarshaling easier.
> http://xstream.codehaus.org/changes.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
