On Wed, Nov 02, 2016 at 19:09 +0100, Uwe Hermann wrote:
>
> Hi,
>
> On Sun, Oct 16, 2016 at 06:25:29PM +0200, Gerhard Sittig wrote:
> > Several checks get applied when loading externally provided protocol
> > decoders. Print error messages when checks fail, so that developers can
> > better resolve issues.
>
> Merged with minimal changes, thanks!
>
>
> > + /*
> > + * The decode_end() method is optional for protocol decoders.
> > + * _If_ we'd check its being callable here, we should cope with
> > + * its absence, which would be acceptable. Some variation of
> > + * check_method() would be needed.
> > + */
>
> This hunk is dropped for now as there's no decode_end() atm.
Oops, I noticed this some two days ago, but did not bother to
follow up in time. Was even thinking of re-writing this patch
for readability. Like immediately emitting a most suitable
message before branching to the error code path. Instead of
"accumulating an error string" which only later gets printed in
ways that might be perceived as "unnatural". You beat me to it
by applying the first implementation. :)
I think the now applied form improves diagnostics from a user's
point of view, and is useful. Tell me if you want me to cleanup
the internal implementation. Otherwise I'll leave it as it is
right now.
virtually yours
Gerhard Sittig
--
If you don't understand or are scared by any of the above
ask your parents or an adult to help you.
------------------------------------------------------------------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi
_______________________________________________
sigrok-devel mailing list
sigrok-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sigrok-devel
